Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced xStorage references with the HQ StorageDsc dsc resource module #1056

Merged
merged 1 commit into from
Mar 4, 2018
Merged

Replaced xStorage references with the HQ StorageDsc dsc resource module #1056

merged 1 commit into from
Mar 4, 2018

Conversation

TraGicCode
Copy link
Contributor

@TraGicCode TraGicCode commented Mar 4, 2018

Pull Request (PR) description
Replace references of xStorage with the renamed StorageDsc dsc resource module.

This Pull Request (PR) fixes the following issues:
Fixes #1038

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Mar 4, 2018

Codecov Report

Merging #1056 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1056   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3930    3930           
====================================
  Hits       3844    3844           
  Misses       86      86

@johlju
Copy link
Member

johlju commented Mar 4, 2018

Closing and reopening this PR to kick off the tests again since the tests seemed to have failed on a temporary error.

@johlju johlju closed this Mar 4, 2018
@johlju johlju reopened this Mar 4, 2018
@johlju johlju added the needs review The pull request needs a code review. label Mar 4, 2018
@johlju
Copy link
Member

johlju commented Mar 4, 2018

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 5e7d4c8 into dsccommunity:dev Mar 4, 2018
@johlju johlju changed the title Replaced xStorage references with the HQ StorageDsc dsc resource module. Replaced xStorage references with the HQ StorageDsc dsc resource module Mar 4, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: xStorage changed name to StorageDsc
3 participants