Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup: Accounts containing '$' will be able to be used #1060

Merged
merged 7 commits into from
Mar 11, 2018
Merged

SqlSetup: Accounts containing '$' will be able to be used #1060

merged 7 commits into from
Mar 11, 2018

Commits on Mar 10, 2018

  1. Added regression test for issue dsccommunity#1055

    @johlju
    johlju committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    35af582 View commit details
    Browse the repository at this point in the history

  2. Clean up tests for helper function Get-ServiceAccountParameters

    @johlju
    johlju committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    907b379 View commit details
    Browse the repository at this point in the history

  3. Changes to SqlSetup 

    - Now accounts containing '$' will be able to be used for installing
  SQL Server. Although, if the account ends with '$' it is considered a
  Managed Service Account (issue dsccommunity#1055).
    @johlju
    johlju committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    7aa20f8 View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @johlju
    johlju committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    7128830 View commit details
    Browse the repository at this point in the history

  5. Added comments

    @johlju
    johlju committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    4c5c13c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2018

  1. Fix review comments at r1

    @johlju
    johlju committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    d1d5e21 View commit details
    Browse the repository at this point in the history

  2. Fix new lint error (from updated version)

    @johlju
    johlju committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    dddde86 View commit details
    Browse the repository at this point in the history