Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE_TEMPLATE: Updated with a note about sensitive information #1093

Merged
merged 3 commits into from
Mar 17, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 17, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #1092

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md? Entry
    should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md?
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help?
  • Comment-based help added/updated?
  • Localization strings added/updated in all localization files as appropriate?
  • Examples appropriately added/updated?
  • Unit tests added/updated?
    See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible)?
    See DSC Resource Testing Guidelines.
  • New/changed code adheres to
    DSC Resource Style Guidelines
    and Best Practices?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 17, 2018
@codecov-io
Copy link

codecov-io commented Mar 17, 2018

Codecov Report

Merging #1093 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1093   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        32      32           
  Lines      3930    3930           
====================================
  Hits       3844    3844           
  Misses       86      86

@johlju
Copy link
Member Author

johlju commented Mar 17, 2018

:LGTM:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 4e323fc into dsccommunity:dev Mar 17, 2018
@johlju johlju deleted the update-issue-template branch March 30, 2018 15:58
@johlju johlju removed the needs review The pull request needs a code review. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISSUE_TEMPLATE: Add a note that sensitive information can be obfuscated
2 participants