Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServiceAccount: Fix unit tests that didn't mock some of the calls #1235

Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 28, 2018

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

- Fix unit tests that didn't mock some of the calls. It no longer fail
  when a SQL Server installation is not present on the node running the
  unit test (issue dsccommunity#983).
@johlju johlju added the needs review The pull request needs a code review. label Sep 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #1235 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1235   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        34      34           
  Lines      4171    4171           
====================================
  Hits       4083    4083           
  Misses       88      88

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 23dae41 into dsccommunity:dev Sep 28, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Sep 28, 2018
@johlju johlju deleted the fix-unit-tests-sqlserviceserviceaccount branch September 28, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServiceAccount: Unit tests fail to run on a machine without SQL Server installed
2 participants