Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerReplication: Added localization #1327

Merged
merged 1 commit into from
May 3, 2019
Merged

SqlServerReplication: Added localization #1327

merged 1 commit into from
May 3, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 23, 2019 •
edited
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Apr 23, 2019
@codecov-io
Copy link

codecov-io commented Apr 23, 2019 •
edited
Loading

Codecov Report

Merging #1327 into dev will decrease coverage by <1%.
The diff coverage is 74%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #1327   +/-   ##
====================================
- Coverage    98%     98%   -1%     
====================================
  Files        36      36           
  Lines      5171    5198   +27     
====================================
+ Hits       5107    5128   +21     
- Misses       64      70    +6

@johlju
Changes to SqlServerReplication
1935299 
- Added en-US localization (issue dsccommunity#620).
- Refactored Get-TargetResource slightly so it provide better verbose
  messages.
@johlju johlju marked this pull request as ready for review May 1, 2019 14:56
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 1, 2019
@johlju
Copy link
Member Author

johlju commented May 1, 2019

Code coverage took a hit because wrapper functions got longer when I added localization. It's is wrapper function for method calls that is not yet tested. I won't fix that in this PR since I feel it is out of scope.

johlju
johlju commented May 2, 2019
View reviewed changes
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit a7add04 into dsccommunity:dev May 3, 2019
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label May 3, 2019
@johlju johlju deleted the fix-issue-620 branch July 17, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlServerReplication: Localization should change to align with HQRM modules
3 participants
@johlju @codecov-io @kwirkykat