-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerEndpoint*: Added localization #1337
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1337 +/- ##
=====================================
+ Coverage 98% 98% +<1%
=====================================
Files 36 36
Lines 5013 5070 +57
=====================================
+ Hits 4944 5001 +57
Misses 69 69 |
- Added en-US localization (issue dsccommunity#613).
- Added en-US localization (issue dsccommunity#611).
- Added en-US localization (issue dsccommunity#612).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion
DSCResources/MSFT_SqlServerEndpoint/MSFT_SqlServerEndpoint.psm1, line 234 at r1 (raw file):
Write-Verbose -Message ('Dropping endpoint {0}.' -f $EndpointName)
This line should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
DSCResources/MSFT_SqlServerEndpoint/MSFT_SqlServerEndpoint.psm1, line 234 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Write-Verbose -Message ('Dropping endpoint {0}.' -f $EndpointName)
This line should be removed.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is