SqlServerDsc: Opt-in for 'Common Test - Validate Localization' #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine DscResource.LocalizationHelper and DscResource.Common into SqlServerDsc.Common (issue dsccommunity#1357).
- Improved verbose message output when creating availability group replica, removing a availability group replica, and joining the availability group replica to the availability group.
johlju
added
the
waiting for code fix
- Opt-in to the common test 'Common Test - Flagged Script Analyzer Rules' ([issue dsccommunity#1101).
Codecov Report
@@ Coverage Diff @@
## dev #1366 +/- ##
=====================================
- Coverage 98% 97% -1%
=====================================
Files 36 35 -1
Lines 5257 5172 -85
=====================================
- Hits 5187 5066 -121
- Misses 70 106 +36 |
johlju
added
needs review
johlju
commented
May 30, 2019
There was a problem hiding this comment.
Reviewed 56 of 58 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
New-TerminatingError,New-WarningMessageand
New-VerboseMessagein favor of the the newlocalization helper functions.
SqlServerDsc.Common (issue Combine DscResource.LocalizationHelper and DscResource.Common into SqlServerDsc.Common #1357).
memory, and when limiting maximum memory.
not in desired state.
of showing a message saying that connect failed another unrelated
error message could have been shown, because of an error in the code.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is