SqlServerDsc: Add .gitattributes file, update analyzersettings.psd1 and fix hashtables #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1447 +/- ##
====================================
- Coverage 98% 98% -1%
====================================
Files 38 38
Lines 5603 5626 +23
====================================
+ Hits 5497 5519 +22
- Misses 106 107 +1 |
|
Closing an reopening after tests have been fixed in the test framework |
- Fix line endings in code which did not use the correct format.
- Fix hashtables to align with style guideline (issue dsccommunity#1437).
johlju
changed the title
johlju
commented
Nov 27, 2019
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 8 of 8 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
johlju
added a commit
that referenced
this pull request
Jan 1, 2020
…nd fix hashtables (#1447) - Changes to SqlServerDsc - Add .gitattributes file to checkout file correctly with CRLF. - Updated .vscode/analyzersettings.psd1 file to correct use PSSA rules and custom rules in VS Code. - Fix hashtables to align with style guideline (issue #1437). - Changes to SqlServerMaxDop - Fix line endings in code which did not use the correct format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
and custom rules in VS Code.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is