BREAKING CHANGE: SqlDatabaseOwner/Permission/Role: Update parameter Database to DatabaseName

[Rob-S]

Pull Request (PR) description

BREAKING CHANGE: Database changed to DatabaseName for consistency with other modules.

This Pull Request (PR) fixes the following issues

• Fixes SqlServerDsc: Inconsistent Naming *Name / DatabaseName / Database / Name #1484
• Fixes README.md: Link to non-existent page on dev branch #1508

Task list

• [✓] Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• [✓] Resource documentation added/updated in README.md.
• [✓] Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• [✓] Comment-based help added/updated.
• [✓] Localization strings added/updated in all localization files as appropriate.
• [✓] Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [✓] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[johlju]

Reviewed 16 of 26 files at r1.
Reviewable status: 14 of 26 files reviewed, 4 unresolved discussions (waiting on @johlju and @Rob-S)

---

CHANGELOG.md, line 8 at r1 (raw file):

## [Unreleased]

There are duplicate Unreleased sections.

---

source/DSCResources/MSFT_SqlDatabaseRole/MSFT_SqlDatabaseRole.psm1, line 22 at r1 (raw file):

RoleName

Not sure we should change this from Name. I think since the resource is named SqlDatabaseRole then it is implicit that the Name means the role name. If community want to change this then we need to change a lot of resources since most follow this pattern.
I suggest renaming RoleName in this resource (only) back to Name (you may keep RoleName on the helper functions though).

---

source/Examples/Resources/SqlDatabaseUser/1-AddDatabaseUserWithLogin.ps1, line 25 at r1 (raw file):

UserName

This should be kept as Name, throughout this file and the other examples for this resource. Since the resource is named SqlDatabaseUser then it is implicit that the Name means the user name.

---

tests/Unit/MSFT_SqlDatabaseOwner.Tests.ps1, line 145 at r1 (raw file):

$result.Database

This should be DatabaseName. Throughout.

[johlju]

Reviewed 13 of 17 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[johlju]

Awesome work on this. This looks great and I will merge soon. I waiting for more breaking changes PR's before I merge so we can release fixes.

I'm working on a breaking PR too but goes slow since I don't have much time at the moment.