-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerDsc: Unit tests run in PowerShell 7 #1524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johlju
added
the
waiting for code fix
A review left open comments, and the pull request is waiting for changes to be pushed by the author.
label
May 3, 2020
johlju
force-pushed
the
fix/run-unit-tests-on-ps7
branch
2 times, most recently
from
May 5, 2020 09:57
bb921c6
to
08e7d07
Compare
- Add integration tests (issue dsccommunity#755)
johlju
force-pushed
the
fix/run-unit-tests-on-ps7
branch
from
May 6, 2020 13:15
7769899
to
48a27a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
======================================
- Coverage 98% 98% -1%
======================================
Files 39 39
Lines 5927 5942 +15
======================================
Hits 5832 5832
- Misses 95 110 +15 |
johlju
added
needs review
The pull request needs a code review.
and removed
waiting for code fix
A review left open comments, and the pull request is waiting for changes to be pushed by the author.
labels
May 7, 2020
Merging this to improve the speed to other PR's. |
johlju
commented
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is