Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Unit tests run in PowerShell 7 #1524

Merged
merged 26 commits into from
May 7, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented May 3, 2020

Pull Request (PR) description

  • SqlServerDsc
    • The CI pipeline now uses the latest version of the module ModuleBuilder.
    • The unit tests now run on PowerShell 7 to optimize the total run time.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label May 3, 2020
@johlju johlju force-pushed the fix/run-unit-tests-on-ps7 branch 2 times, most recently from bb921c6 to 08e7d07 Compare May 5, 2020 09:57
@johlju johlju force-pushed the fix/run-unit-tests-on-ps7 branch from 7769899 to 48a27a4 Compare May 6, 2020 13:15
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #1524 into master will decrease coverage by 0%.
The diff coverage is 13%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1524   +/-   ##
======================================
- Coverage      98%     98%   -1%     
======================================
  Files          39      39           
  Lines        5927    5942   +15     
======================================
  Hits         5832    5832           
- Misses         95     110   +15     

@johlju johlju marked this pull request as ready for review May 7, 2020 11:32
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels May 7, 2020
@johlju
Copy link
Member Author

johlju commented May 7, 2020

Merging this to improve the speed to other PR's.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 56afa40 into dsccommunity:master May 7, 2020
@johlju johlju deleted the fix/run-unit-tests-on-ps7 branch May 7, 2020 11:34
@johlju johlju removed the needs review The pull request needs a code review. label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant