-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerDsc: Update module to use auto-documentation #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johlju
commented
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 35 of 35 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
johlju
added
waiting for code fix
A review left open comments, and the pull request is waiting for changes to be pushed by the author.
and removed
needs review
The pull request needs a code review.
labels
Jun 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
======================================
Coverage 98% 98%
======================================
Files 37 37
Lines 6074 6074
======================================
Hits 5970 5970
Misses 104 104 |
johlju
added
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
and removed
waiting for code fix
A review left open comments, and the pull request is waiting for changes to be pushed by the author.
labels
Jun 25, 2020
johlju
removed
the
ready for merge
The pull request was approved by the community and is ready to be merged by a maintainer.
label
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is