Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlDatabaseObjectPermission: Update documentation #1581

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 2, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

- Since the task that publish Wiki content was updated to correctly handle
  embedded instances the duplicate documentation was removed from the
  resource README.md, and some was added to the schema MOF parameter
  descriptions (issue dsccommunity#1580).
@johlju johlju added the needs review The pull request needs a code review. label Jul 2, 2020
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit ec31280 into dsccommunity:master Jul 3, 2020
@johlju johlju deleted the fix/remove-doc-sqldatabaseobjectpermission branch July 3, 2020 18:39
@johlju johlju removed the needs review The pull request needs a code review. label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlDatabaseObjectPermission: Remove duplicate documentation for embedded instance
1 participant