Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Switch to GitHub Action Stale #1667

Merged
merged 4 commits into from
Jan 23, 2021
Merged

SqlServerDsc: Switch to GitHub Action Stale #1667

merged 4 commits into from
Jan 23, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 9, 2021

Pull Request (PR) description

  • SqlServerDsc
    • Switch to GitHub Action Stale instead of GitHub App (Probot) Stale.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #1667 (694a10e) into main (c392042) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1667   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6259    6259           
====================================
  Hits       6102    6102           
  Misses      157     157           
Flag Coverage Δ
unit 97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@johlju
Copy link
Member Author

johlju commented Jan 10, 2021

Closing this as the GitHub action Stale currently cannot be configured to not close PR's. That is currently being prosed in PR actions/stale#224 so waiting for that until continue with this PR.

@johlju johlju closed this Jan 10, 2021
@johlju
Copy link
Member Author

johlju commented Jan 16, 2021

The PR actions/stale#224 was just merged switch new options that we needed. Reopening this PR.

@johlju johlju reopened this Jan 16, 2021
@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jan 16, 2021
@johlju johlju force-pushed the johlju-patch-1 branch 2 times, most recently from 9e9bd5d to 8caf6ec Compare January 16, 2021 15:29
@johlju johlju added on hold The issue or pull request has been put on hold by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jan 16, 2021
@johlju
Copy link
Member Author

johlju commented Jan 16, 2021

Waiting on a newer release than 3.0.14. See latest release https://github.com/marketplace/actions/close-stale-issues or all releases https://github.com/actions/stale/releases.

@johlju johlju added needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Jan 22, 2021
@johlju
Copy link
Member Author

johlju commented Jan 22, 2021

New release was just released.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju changed the title SqlServer: Switch to GitHub Action Stale SqlServerDsc: Switch to GitHub Action Stale Jan 23, 2021
@johlju johlju merged commit c00e23a into main Jan 23, 2021
@johlju johlju deleted the johlju-patch-1 branch January 23, 2021 09:42
@johlju johlju removed the needs review The pull request needs a code review. label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant