-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlLogin: Update/Fix to CHANGELOG.md comments relating to PR #1652 #1670
Merged
johlju
merged 12 commits into
dsccommunity:main
from
SphenicPaul:pjw-issue361-ChangeLogPostFix
Jan 12, 2021
Merged
SqlLogin: Update/Fix to CHANGELOG.md comments relating to PR #1652 #1670
johlju
merged 12 commits into
dsccommunity:main
from
SphenicPaul:pjw-issue361-ChangeLogPostFix
Jan 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serverInstance is not obtained
…ObtainServerInstance' error message
Merging changes from 'dsccommunity/SqlServerDsc' main.
Merging from DscCommunity\SqlServerDsc
…asswordPolicyEnforced' changes.
9 tasks
johlju
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
@SphenicPaul thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Update to
CHANGELOG.md
to correct the change/PR (#1652) made aroundPasswordExpirationEnabled
andPasswordPolicyEnforced
properties/parameters. This change was previously described as a sequencing/order change, but the final change implemented was one that updates both properties together.This Pull Request (PR) fixes the following issues
None
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is