Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRSSetup: Fix SuppressRestart to not be added when $false #1673

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 16, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 16, 2021
@johlju johlju changed the title Fix SuppressRestart to not be added when $false SqlRSSetup: Fix SuppressRestart to not be added when $false Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #1673 (e9b1fb5) into main (9130c05) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1673   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6258    6259    +1     
====================================
+ Hits       6101    6102    +1     
  Misses      157     157           
Flag Coverage Δ
unit 97% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce/DSCResources/DSC_SqlRSSetup/DSC_SqlRSSetup.psm1 100% <100%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit c392042 into dsccommunity:main Jan 21, 2021
@johlju johlju deleted the fix/issue#1401 branch January 21, 2021 17:17
@johlju johlju removed the needs review The pull request needs a code review. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlRSSetup: SuppressRestart added to argument list even when set to $false
1 participant