Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-pipelines.yml #1715

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Update azure-pipelines.yml #1715

merged 6 commits into from
Aug 30, 2021

Conversation

akbhuker
Copy link
Contributor

@akbhuker akbhuker commented Aug 26, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1715 (75417d5) into main (2bc90f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1715   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6325    6325           
====================================
  Hits       6169    6169           
  Misses      156     156           
Flag Coverage Δ
unit 97% <ø> (ø)

@johlju johlju added the needs review The pull request needs a code review. label Aug 27, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @akbhuker)

a discussion (no related file):
Please update this PR according to #1713 (comment).


a discussion (no related file):
Please add an entry to the CHANGELOG.md (that will make the HQRM tests to pass).


@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Aug 27, 2021
@johlju
Copy link
Member

johlju commented Aug 29, 2021

@akbhuker please add an entry to the CHANGELOG.md as well, in the appropriate location under the section UNRELEASED.

@akbhuker akbhuker changed the title Update vmImage windows-2019 to windows-2022 Update azure.pipelines.yml Aug 30, 2021
@akbhuker akbhuker changed the title Update azure.pipelines.yml Update azure-pipelines.yml Aug 30, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @akbhuker)

@johlju
Copy link
Member

johlju commented Aug 30, 2021

@akbhuker awesome! Thank you for this. 🙇 Will merge as soon as all the tests passes.

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Aug 30, 2021
@johlju johlju merged commit 059f867 into dsccommunity:main Aug 30, 2021
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Aug 30, 2021
@johlju
Copy link
Member

johlju commented Aug 30, 2021

@akbhuker I saw now that the entries in the change log was at the end of the file, instead of under the Unreleased section. But no worries, I will fix that in a separate PR. 🙂 Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should add Windows Server 2022 as an additional OS for our integration tests
2 participants