Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Issue 1712: CredScan password fix #1716

Merged
merged 2 commits into from
Aug 27, 2021
Merged

SqlServerDsc: Issue 1712: CredScan password fix #1716

merged 2 commits into from
Aug 27, 2021

Conversation

ericscheffler
Copy link
Contributor

@ericscheffler ericscheffler commented Aug 26, 2021

Pull Request (PR) description

Example passwords triggering CredScan
Updated comments with sample password format that is ignored by CredScan per the tool documentation.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1716 (845c16e) into main (ddc86c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1716   +/-   ##
====================================
  Coverage    97%     97%           
====================================
  Files        38      38           
  Lines      6325    6325           
====================================
  Hits       6169    6169           
  Misses      156     156           
Flag Coverage Δ
unit 97% <ø> (ø)
Impacted Files Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 97% <ø> (ø)

@johlju johlju added the needs review The pull request needs a code review. label Aug 27, 2021
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ericscheffler)

@johlju johlju merged commit 2bc90f3 into dsccommunity:main Aug 27, 2021
@johlju johlju removed the needs review The pull request needs a code review. label Aug 27, 2021
@johlju
Copy link
Member

johlju commented Aug 27, 2021

@ericscheffler thank you for reporting this and fixing it! I make sure to publish a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example passwords triggering CredScan
3 participants