Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAGReplica: Converted unit tests to Pester 5 #1820

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 14, 2022

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Dec 14, 2022
@johlju
Copy link
Member Author

johlju commented Dec 14, 2022

I converted the tests for Get so far. The rest are coming in other commits.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1820 (c3b7b2e) into main (d5692e2) will increase coverage by 2%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           main   #1820    +/-   ##
=====================================
+ Coverage    88%     90%    +2%     
=====================================
  Files        82      82            
  Lines      7437    7437            
=====================================
+ Hits       6588    6737   +149     
+ Misses      849     700   -149     
Flag Coverage Δ *Carryforward flag
unit 90% <100%> (+2%) ⬆️ Carriedforward from bee3ad5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...SCResources/DSC_SqlAGReplica/DSC_SqlAGReplica.psm1 75% <100%> (+75%) ⬆️

@johlju
Copy link
Member Author

johlju commented Dec 15, 2022

Converted Set-TargetResource. I will convert Test-TargetResource tomorrow.

@johlju johlju marked this pull request as ready for review December 16, 2022 10:20
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Dec 16, 2022
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 92612af into dsccommunity:main Dec 16, 2022
@johlju johlju deleted the fix/unit-test-SqlAgReplica branch December 16, 2022 13:33
@johlju johlju removed the needs review The pull request needs a code review. label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant