Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRs and SqlRSSetup: re-enable integration tests #1849

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 6, 2023

Pull Request (PR) description

Re-enable integration tests.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1849 (7315762) into main (e65a410) will not change coverage.
The diff coverage is n/a.

❗ Current head 7315762 differs from pull request most recent head 9453cce. Consider uploading reports for the commit 9453cce to get more accurate results

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1849   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        85      85           
  Lines      7614    7614           
====================================
  Hits       7012    7012           
  Misses      602     602           
Flag Coverage Δ
unit 92% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion


appveyor.yml line 27 at r2 (raw file):

  # DEBUG: Comment and un-comment the different SQL Server version that should be tested.
  #- TEST_CONFIGURATION: Integration_SQL2016
  #- TEST_CONFIGURATION: Integration_SQL2017

Should revert this.

Code quote:

  #- TEST_CONFIGURATION: Integration_SQL2016
  #- TEST_CONFIGURATION: Integration_SQL2017

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, all discussions resolved


appveyor.yml line 27 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should revert this.

Done

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 2e28a29 into dsccommunity:main Mar 4, 2023
@johlju johlju deleted the fix/re-enable-tests branch March 4, 2023 16:33
@johlju johlju removed the needs review The pull request needs a code review. label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlRS and SqlRSSetup: Unable to run integration tests for Reporting Services 2019 - missing setup executable
1 participant