-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlRs and SqlRSSetup: re-enable integration tests #1849
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
====================================
Coverage 92% 92%
====================================
Files 85 85
Lines 7614 7614
====================================
Hits 7012 7012
Misses 602 602
|
e2cccbc
to
f9b3175
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion
appveyor.yml
line 27 at r2 (raw file):
# DEBUG: Comment and un-comment the different SQL Server version that should be tested. #- TEST_CONFIGURATION: Integration_SQL2016 #- TEST_CONFIGURATION: Integration_SQL2017
Should revert this.
Code quote:
#- TEST_CONFIGURATION: Integration_SQL2016
#- TEST_CONFIGURATION: Integration_SQL2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
appveyor.yml
line 27 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Should revert this.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
Pull Request (PR) description
Re-enable integration tests.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is