-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xSQLServerScript: Fixing PSSA errors #764
Conversation
@ChrisLGardner, |
Codecov Report
@@ Coverage Diff @@
## dev #764 +/- ##
===================================
Coverage 97% 97%
===================================
Files 30 30
Lines 3250 3250
===================================
Hits 3165 3165
Misses 85 85 |
@ChrisLGardner Thanks for fixing this and the others! Please add this change to the CHANGELOG.md. |
Done. |
Reviewed 1 of 1 files at r1, 1 of 1 files at r3. CHANGELOG.md, line 55 at r3 (raw file):
Please use lower-case 'i' in issue to be consequent with the other entries. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. CHANGELOG.md, line 55 at r3 (raw file):
Please remove on of the dashes here as well. Comments from Reviewable |
Review status: 1 of 2 files reviewed at latest revision, 2 unresolved discussions. CHANGELOG.md, line 55 at r3 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. CHANGELOG.md, line 55 at r3 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r4. Comments from Reviewable |
Pull Request (PR) description
As raised in #728 there are various ScriptAnalyzer errors from the parameters being marked as Mandatory = $false, this resolves those errors.
This Pull Request (PR) fixes the following issues:
Fixes #728
Task list:
This change is