Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerScript: Fixing PSSA errors #764

Merged
merged 4 commits into from
Aug 16, 2017
Merged

xSQLServerScript: Fixing PSSA errors #764

merged 4 commits into from
Aug 16, 2017

Conversation

ChrisLGardner
Copy link
Contributor

@ChrisLGardner ChrisLGardner commented Aug 15, 2017

Pull Request (PR) description
As raised in #728 there are various ScriptAnalyzer errors from the parameters being marked as Mandatory = $false, this resolves those errors.

This Pull Request (PR) fixes the following issues:
Fixes #728

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@msftclas
Copy link

@ChrisLGardner,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

codecov-io commented Aug 15, 2017

Codecov Report

Merging #764 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #764   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        30     30           
  Lines      3250   3250           
===================================
  Hits       3165   3165           
  Misses       85     85

@johlju johlju added the needs review The pull request needs a code review. label Aug 16, 2017
@johlju
Copy link
Member

johlju commented Aug 16, 2017

@ChrisLGardner Thanks for fixing this and the others! Please add this change to the CHANGELOG.md.

@johlju johlju changed the title [xSqlServerScript]Fixing PSSA errors - Fixes #728 xSqlServerScript: Fixing PSSA errors Aug 16, 2017
@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Aug 16, 2017
@ChrisLGardner
Copy link
Contributor Author

Done.

@johlju johlju added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Aug 16, 2017
@johlju
Copy link
Member

johlju commented Aug 16, 2017

Reviewed 1 of 1 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 55 at r3 (raw file):

[Issue #728]

Please use lower-case 'i' in issue to be consequent with the other entries.


Comments from Reviewable

@johlju
Copy link
Member

johlju commented Aug 16, 2017

Review status: all files reviewed at latest revision, 2 unresolved discussions.


CHANGELOG.md, line 55 at r3 (raw file):

- -

Please remove on of the dashes here as well.


Comments from Reviewable

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Aug 16, 2017
@ChrisLGardner
Copy link
Contributor Author

Review status: 1 of 2 files reviewed at latest revision, 2 unresolved discussions.


CHANGELOG.md, line 55 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

[Issue #728]

Please use lower-case 'i' in issue to be consequent with the other entries.

Done.


CHANGELOG.md, line 55 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Please remove on of the dashes here as well.

Done.


Comments from Reviewable

@johlju johlju added needs review The pull request needs a code review. and removed waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Aug 16, 2017
@johlju
Copy link
Member

johlju commented Aug 16, 2017

:lgtm:


Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju changed the title xSqlServerScript: Fixing PSSA errors xSQLServerScript: Fixing PSSA errors Aug 16, 2017
@johlju johlju merged commit e0d6ec1 into dsccommunity:dev Aug 16, 2017
@vors vors removed the needs review The pull request needs a code review. label Aug 16, 2017
@ChrisLGardner ChrisLGardner deleted the issue-728 branch August 24, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerScript: PSScriptAnalyzer errors need to be fixed
5 participants