Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerAlwaysOnService: IsHadrEnabled is cast to [System.Boolean] #768

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 16, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #763

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 16, 2017
@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #768 into dev will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #768   +/-   ##
===================================
- Coverage    97%    97%   -1%     
===================================
  Files        30     30           
  Lines      3250   3245    -5     
===================================
- Hits       3165   3160    -5     
  Misses       85     85

- Casting the result of the property IsHadrEnabled to [System.Boolean] so that
  $null is never returned, which resulted in an exception (issue dsccommunity#763).
@johlju johlju force-pushed the fix-xSQLServerAlwaysOnService branch from b4b3f40 to 275eac8 Compare August 17, 2017 15:12
@johlju
Copy link
Member Author

johlju commented Aug 18, 2017

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit f844cc7 into dsccommunity:dev Aug 18, 2017
@vors vors removed the needs review The pull request needs a code review. label Aug 18, 2017
@johlju johlju deleted the fix-xSQLServerAlwaysOnService branch August 19, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerAlwaysOnService: Returns IsHadrEnabled -eq $null
4 participants