Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerRSConfig: Added integration test #834

Merged
merged 7 commits into from
Sep 22, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 20, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #753

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju changed the title X sql server rs config integration xSQLServerRSConfig: Added integration test Sep 20, 2017
@johlju johlju added the needs review The pull request needs a code review. label Sep 20, 2017
@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #834 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #834   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        31     31           
  Lines      3314   3314           
===================================
  Hits       3197   3197           
  Misses      117    117

@johlju
Copy link
Member Author

johlju commented Sep 21, 2017

Will add additional tests for this to verify that the sites actually responds. So labeling this "Waiting for author".

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Sep 21, 2017
@johlju
Copy link
Member Author

johlju commented Sep 21, 2017

This PR will fail the tests until PR #837 has been merged.

@johlju johlju force-pushed the xSQLServerRSConfig-integration branch from 7bbcb55 to 3d8fc1a Compare September 22, 2017 05:00
@johlju
Copy link
Member Author

johlju commented Sep 22, 2017

:LGTM.


Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Sep 22, 2017

:LGTM:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@johlju johlju removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Sep 22, 2017
@johlju johlju merged commit 9ce87a8 into dsccommunity:dev Sep 22, 2017
@johlju johlju deleted the xSQLServerRSConfig-integration branch October 7, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xSQLServerRSConfig: Integration test is missing for this resource
3 participants