-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: xSQLServerNetwork: Support for configuring SQL Server to use a static port #887
BREAKING CHANGE: xSQLServerNetwork: Support for configuring SQL Server to use a static port #887
Conversation
…ssue #855. Modified MOF and unit tests to reflect changes.
Codecov Report
@@ Coverage Diff @@
## dev #887 +/- ##
====================================
+ Coverage 96% 96% +<1%
====================================
Files 31 31
Lines 3430 3436 +6
====================================
+ Hits 3311 3317 +6
Misses 119 119 |
Thanks for localizing this one as well! There was a strange error in the tests when run in the AppVeyor. Had nothing to do with this PR. If it persists I have to look into it. Hope it was a temporary glitch and it works when you push next commit. 😄 Reviewed 8 of 8 files at r1. CHANGELOG.md, line 24 at r1 (raw file):
Please add 'BREAKING CHANGE:' before this entry. CHANGELOG.md, line 24 at r1 (raw file):
I think we should end each sentence with a full stop (.) . CHANGELOG.md, line 25 at r1 (raw file):
Should this word be "when"? CHANGELOG.md, line 27 at r1 (raw file):
Please add reference to the issue here as well. README.md, line 979 at r1 (raw file):
TcpDynamicPort DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 42 at r1 (raw file):
I think the values should be switched here? DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 142 at r1 (raw file):
Could you please change to the new helper functions (to align with the other resources modules). DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 321 at r1 (raw file):
Please use named parameters, DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.schema.mof, line 4 at r1 (raw file):
Should we leave this as Comments from Reviewable |
Review status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks failed. CHANGELOG.md, line 24 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. CHANGELOG.md, line 24 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. CHANGELOG.md, line 25 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. CHANGELOG.md, line 27 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. README.md, line 979 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 42 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 142 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 321 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.schema.mof, line 4 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. I did not see that discussion until after I had completed this change. I will change them all back to InstanceName. Comments from Reviewable |
Reviewed 7 of 7 files at r2. README.md, line 984 at r2 (raw file):
TcpDynamicPort DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 13 at r2 (raw file):
InstanceName DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 73 at r2 (raw file):
InstanceName DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 244 at r2 (raw file):
InstanceName Comments from Reviewable |
Review status: all files reviewed at latest revision, 4 unresolved discussions. README.md, line 984 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 13 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 73 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. DSCResources/MSFT_xSQLServerNetwork/MSFT_xSQLServerNetwork.psm1, line 244 at r2 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Comments from Reviewable |
Reviewed 2 of 2 files at r3. Comments from Reviewable |
Pull Request (PR) description
Corrects an issue where changing from a dynamic to a static TCP port is not possible. This PR renamed the parameter TcpDynamicPorts to TcpDynamicPort and changed its type to Boolean. Additionally, localization for en-US was added in support of the (localization project).
This Pull Request (PR) fixes the following issues:
Task list:
This change is