Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerEndpointPermission: Fix long path issue for examples #935

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 5, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #934

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Dec 5, 2017
@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #935 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #935   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3515   3515           
===================================
  Hits       3395   3395           
  Misses      120    120

@johlju
Copy link
Member Author

johlju commented Dec 5, 2017

Closing and reopening to kick off the tests again.

@johlju johlju closed this Dec 5, 2017
@johlju johlju reopened this Dec 5, 2017
@vors vors removed the needs review The pull request needs a code review. label Dec 5, 2017
@johlju johlju added the needs review The pull request needs a code review. label Dec 5, 2017
@johlju
Copy link
Member Author

johlju commented Dec 6, 2017

Again. Closing and reopening to kick off the tests again.

@johlju johlju closed this Dec 6, 2017
@vors vors removed the needs review The pull request needs a code review. label Dec 6, 2017
@johlju johlju reopened this Dec 6, 2017
- Now the examples files have a shorter name so that resources will not fail
  to compile in Azure Automation (issue dsccommunity#934).
@johlju
Copy link
Member Author

johlju commented Dec 7, 2017

:LGTM:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju merged commit 130ea8e into dsccommunity:dev Dec 7, 2017
@johlju johlju deleted the fix-long-path branch December 7, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Still issue compiling in Azure Automation
3 participants