Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServiceAccount: Parameter RestartService more descriptive in README.md #962

Merged
merged 2 commits into from
Dec 24, 2017
Merged

SqlServiceAccount: Parameter RestartService more descriptive in README.md #962

merged 2 commits into from
Dec 24, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 23, 2017 •
edited by joeyaiello
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #960

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju
Changes to SqlServiceAccount
7f4926b 
- Made the description of parameter RestartService more descriptive (issue dsccommunity#960).
@johlju
Fix typo in examples
4a51a84
@johlju johlju added the needs review The pull request needs a code review. label Dec 23, 2017
@johlju johlju changed the title SqlServiceAccount: Made the description of parameter RestartService more descriptive SqlServiceAccount: Parameter RestartService more descriptive in README.md Dec 23, 2017
@johlju
Copy link
Member Author

johlju commented Dec 24, 2017

:lgtm:

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@johlju johlju merged commit 62f7e92 into dsccommunity:dev Dec 24, 2017
@johlju johlju removed the needs review The pull request needs a code review. label Dec 24, 2017
@johlju johlju deleted the fix-parameter-description branch January 6, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to ensure SQL Service ,sqlagent service is running
1 participant
@johlju