Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Update manifest and license to reflect new year #989

Merged
merged 2 commits into from
Jan 1, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 31, 2017

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #965

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Dec 31, 2017
@johlju
Copy link
Member Author

johlju commented Dec 31, 2017

Happy New Year everyone! 🎆

- Updated manifest and license to reflect the new year (issue dsccommunity#965).
@codecov-io
Copy link

codecov-io commented Jan 1, 2018

Codecov Report

Merging #989 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #989   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3765   3765           
===================================
  Hits       3645   3645           
  Misses      120    120

@johlju
Copy link
Member Author

johlju commented Jan 1, 2018

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 5 at r1 (raw file):

## Unreleased

- Changes to SqlServer

Should be SqlServerDsc


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jan 1, 2018

Review status: 2 of 3 files reviewed at latest revision, 1 unresolved discussion.


CHANGELOG.md, line 5 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should be SqlServerDsc

Done.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jan 1, 2018

:LGTM:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju johlju removed the needs review The pull request needs a code review. label Jan 1, 2018
@johlju johlju merged commit d06d253 into dsccommunity:dev Jan 1, 2018
@johlju johlju deleted the change-year branch January 1, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: Update manifest and license with the new year 2018
2 participants