BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove resource in favor of SqlRS

[johlju]

Pull Request (PR) description

• Changes to SqlServerDsc
  • BREAKING CHANGE: Resource SqlRSSecureConnectionLevel was remove (issue BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove this resource #990).
    The parameter that was set using that resource has been merged into resource
    SqlRS as the parameter UseSsl. The UseSsl parameter is of type boolean. This
    change was made because from SQL Server 2008 R2 this value is made an on/off
    switch. Read more in the article ConfigurationSetting Method - SetSecureConnectionLevel.
• Changes to SqlRS
  • Added parameter UseSsl which when set to $true forces connections to the
    Reporting Services to use SSL when connecting (issue BREAKING CHANGE: SqlRSSecureConnectionLevel: Remove this resource #990).

This Pull Request (PR) fixes the following issues:
Fixes #990
Fixes #754
Fixes #635
Fixes #623
Fixes #586
Fixes #585
Fixes #584
Fixes #583
Fixes #296
Fixes #265

Task list:

• Change details added to Unreleased section of CHANGELOG.md?
• Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
• Examples appropriately updated?
• New/changed code adheres to Style Guidelines?
• Unit and (optional) Integration tests created/updated where possible?

---

This change is 

[codecov-io]

Codecov Report

Merging #991 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #991   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3874   3874           
===================================
  Hits       3754   3754           
  Misses      120    120

[johlju]

Reviewed 2 of 12 files at r1.
Review status: 2 of 12 files reviewed at latest revision, 4 unresolved discussions.

---

README.md, line 142 at r1 (raw file):

SqlServerDatabaseMail resource
to manage SQL Server Database Mail.

This should not be in this PR. How did this entry got into this PR? 🤔

---

README.md, line 703 at r1 (raw file):

  initialized.

#### Examples

Missing new example here.

---

README.md, line 806 at r1 (raw file):

* Target machine must be running Windows Server 2008 R2 or later.
* Target machine must be running SQL Server Database Engine 2008 or later.
* Target machine must be running SQL Server Agent.

This should not be here.

---

README.md, line 827 at r1 (raw file):

* [Configure a instance to have 'Priority Boost' enabled](/Examples/Resources/SqlServerConfiguration/2-ConfigureInstanceToEnablePriorityBoost.ps1)

### SqlServerDatabaseMail

This should not be here.

---

Comments from Reviewable

[johlju]

Review status: 1 of 12 files reviewed at latest revision, 4 unresolved discussions.

---

README.md, line 142 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

SqlServerDatabaseMail resource
to manage SQL Server Database Mail.

This should not be in this PR. How did this entry got into this PR? 🤔

Done.

---

README.md, line 806 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should not be here.

Done.

---

README.md, line 827 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should not be here.

Done.

---

Comments from Reviewable

[johlju]

Reviewed 10 of 12 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1, line 145 at r2 (raw file):

        If not specified, 'http://+:80' URL reservation will be used.

    .PARAMETER ReportsReservedUrl

Wrong parameter name.

---

DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1, line 176 at r2 (raw file):

        ```

        SecureConnectionLevel:

Make a not that this is about the UseSsl parameter.

---

Comments from Reviewable

[johlju]

Review status: 10 of 12 files reviewed at latest revision, 3 unresolved discussions.

---

README.md, line 703 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Missing new example here.

Done.

---

DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1, line 145 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Wrong parameter name.

Done.

---

DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1, line 176 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Make a not that this is about the UseSsl parameter.

Done.

---

Comments from Reviewable

[johlju]

---

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable