Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Updated README.md with a known issue section #995

Merged
merged 2 commits into from
Jan 6, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 4, 2018

Pull Request (PR) description

  • Changes to SqlServerDsc
    • Updated README.md with known issue section for each resource.
    • Resources that did not have a description in the README.md now has one.
    • Resources that missed links to the examples in the README.md now has those
      links.
  • Changes to SqlServerEndpoint

This Pull Request (PR) fixes the following issues:
Fixes #504

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

- Changes to SqlServerDsc
  - Updated README.md with known issue section for each resource.
  - Resources that did not have a description in the README.md now has one.
  - Resources that missed links to the examples in the README.md now has those
    links.
- Changes to SqlServerEndpoint
  - Updated README.md with links to the examples
@johlju johlju added the needs review The pull request needs a code review. label Jan 4, 2018
@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #995 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #995   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        32     32           
  Lines      3904   3904           
===================================
  Hits       3817   3817           
  Misses       87     87

@johlju
Copy link
Member Author

johlju commented Jan 5, 2018

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Member Author

johlju commented Jan 5, 2018

:LGTM:

Merging this PR tonight if there are not other review comments.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@johlju johlju merged commit 7516394 into dsccommunity:dev Jan 6, 2018
@johlju johlju deleted the known-issues-readme branch January 6, 2018 10:27
@johlju johlju removed the needs review The pull request needs a code review. label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerEndpoint: Examples are not added to the README.md
2 participants