Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Style Violations in StorageDsc.Common.psm1 #153

Closed
PlagueHO opened this issue Jun 6, 2018 · 0 comments · Fixed by #174
Closed

Correct Style Violations in StorageDsc.Common.psm1 #153

PlagueHO opened this issue Jun 6, 2018 · 0 comments · Fixed by #174
Assignees
@PlagueHO
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Jun 6, 2018

There are some style violations in the StorageDsc.Common.psm1 - specifically in the parameters block of the functions:

  • Assert-DriveLetterValid
  • Assert-AccessPathValid

The [Parameter()] is not in the correct format or missing. The type accelerators are also being used which is not the case in the other functions.
@PlagueHO PlagueHO added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jun 6, 2018
@PlagueHO PlagueHO mentioned this issue Sep 25, 2018
Merged
9 tasks
@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 25, 2018
PlagueHO added a commit that referenced this issue Sep 26, 2018
@PlagueHO
Merge pull request #174 from PlagueHO/Issue-153
d812970 
Correct style violations in support modules - Fixes #153
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct style violations in support modules - Fixes #153 PlagueHO/StorageDsc
2 participants
@johlju @PlagueHO