Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xDisk does not set disk label if disk already exists #37

Closed
gigi81 opened this issue Jun 9, 2016 · 2 comments · Fixed by #170
Closed

xDisk does not set disk label if disk already exists #37

gigi81 opened this issue Jun 9, 2016 · 2 comments · Fixed by #170
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.

Comments

@gigi81
Copy link
Contributor

gigi81 commented Jun 9, 2016

On the xDisk dsc resource the following happens when a disk already exists but the disk label does not match the configured value:

  • Test-DscResource return false (correct because the label does not match)
  • Set-DscResource doesn't set the label (incorrect, should set the label)
gigi81 added a commit to gigi81/xStorage that referenced this issue Jun 9, 2016
@gigi81
xDisk: Fixed bug not setting disk label
6c7dd69 
Fix bug dsccommunity#37
@gigi81 gigi81 mentioned this issue Jun 9, 2016
Merged
@kwirkykat kwirkykat added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Aug 19, 2016
TravisEz13 pushed a commit that referenced this issue Aug 28, 2016
@gigi81 @TravisEz13
xDisk: Fixed bug not setting disk label (#38)
8dd1616 
* xDisk: Fixed bug not setting disk label

Fix bug #37

* xDisk unit test fixed wrong DSCModuleName

* Re-applied fix where volume doesn't have a drive letter assigned

* Added changed FSLabel tests

* Removed comma
@PlagueHO
Copy link
Member

I think this one is fixed so can be closed.

@TravisEz13
Copy link
Contributor

Closing based on comments

@PlagueHO PlagueHO mentioned this issue Sep 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added PartitionStyle Parameter to Disk - Fixes #137 PlagueHO/StorageDsc
4 participants
@gigi81 @kwirkykat @PlagueHO @TravisEz13