Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashtable format - Fixes #219 #220

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Nov 16, 2019

Pull Request (PR) description

Correct Hashtable Style.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Nov 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #220 into dev will decrease coverage by <1%.
The diff coverage is 81%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #220   +/-   ##
==================================
- Coverage   95%    95%   -1%     
==================================
  Files        7      7           
  Lines      980    985    +5     
==================================
+ Hits       939    943    +4     
- Misses      41     42    +1

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 03e8be0 into dsccommunity:dev Nov 23, 2019
@PlagueHO PlagueHO deleted the Issue-219 branch November 23, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Hashtable Format
3 participants