-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new CI Pipeline - Fixes #225 #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 88 of 88 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
azure-pipelines.yml, line 5 at r1 (raw file):
include: - master paths:
We should change this to this: https://github.com/dsccommunity/ActiveDirectoryDsc/blob/a454340a558e36add927863dd8b6baed241c87e9/azure-pipelines.yml#L5-L7
Then it will only run CI on changes to source (but still run all PR's).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @johlju - should be good to go!
Reviewable status: 87 of 88 files reviewed, 1 unresolved discussion (waiting on @johlju)
azure-pipelines.yml, line 5 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We should change this to this: https://github.com/dsccommunity/ActiveDirectoryDsc/blob/a454340a558e36add927863dd8b6baed241c87e9/azure-pipelines.yml#L5-L7
Then it will only run CI on changes to source (but still run all PR's).
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This PR updates the module to use the new CI pipeline. It also addresses (but does not close it) #227.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
@johlju - would you mind reviewing for me when you have a moment?
This change is