Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new CI Pipeline - Fixes #225 #228

Merged
merged 16 commits into from
Apr 14, 2020
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 13, 2020

Pull Request (PR) description

This PR updates the module to use the new CI pipeline. It also addresses (but does not close it) #227.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me when you have a moment?


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Apr 13, 2020
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 88 of 88 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)


azure-pipelines.yml, line 5 at r1 (raw file):

    include:
    - master
  paths:

We should change this to this: https://github.com/dsccommunity/ActiveDirectoryDsc/blob/a454340a558e36add927863dd8b6baed241c87e9/azure-pipelines.yml#L5-L7

Then it will only run CI on changes to source (but still run all PR's).

Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johlju - should be good to go!

Reviewable status: 87 of 88 files reviewed, 1 unresolved discussion (waiting on @johlju)


azure-pipelines.yml, line 5 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

We should change this to this: https://github.com/dsccommunity/ActiveDirectoryDsc/blob/a454340a558e36add927863dd8b6baed241c87e9/azure-pipelines.yml#L5-L7

Then it will only run CI on changes to source (but still run all PR's).

Done.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Apr 14, 2020
@PlagueHO PlagueHO merged commit e372594 into dsccommunity:dev Apr 14, 2020
@PlagueHO PlagueHO deleted the Issue-225 branch April 14, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageDsc: Converting to new CI pipeline
2 participants