Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipeline tasks to latest version #257

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 18, 2021

Pull Request (PR) description

This PR updates the pipeline to use the *pipeline tasks.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - could you review when you have time?


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #257 (54c510d) into main (e35daa3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #257   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines       882    882           
===================================
  Hits        842    842           
  Misses       40     40           

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit 7aa733b into dsccommunity:main Apr 21, 2021
@PlagueHO PlagueHO deleted the Minor-Pipeline-Fixes branch April 22, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants