Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiskIdentifier: Add FriendlyName as a disk identifier to Disk, DiskAccessPath and Wai… #269

Merged
merged 9 commits into from
Jan 26, 2023

Conversation

dshelb
Copy link
Contributor

@dshelb dshelb commented Jan 25, 2023

Pull Request (PR) description

This PR introduces support for using disk friendly name as a disk identifier in disk-related resources Disk, DiskAccessPath and WaitForDisk. It also pins the build agent vmAgent to ubuntu-20.04.

This Pull Request (PR) fixes the following issues
Fixes #268
Fixes #270

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • [ x] Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the build passes, this is :lgtm:

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dshelb)

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dshelb)


CHANGELOG.md line 24 at r3 (raw file):

- Added support to use disk FriendlyName as a disk identifer - Fixes [Issue #268](https://github.com/dsccommunity/StorageDsc/issues/268).
- Pin Azure build agent vmImage to ubuntu-20.04  - Fixes [Issue #270] (https://github.com/dsccommunity/StorageDsc/issues/270).
- Remove confirmation prompt when Clear-Disk is called

Nit: can you add a full stop at the end of this line?

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #269 (ba349ef) into main (7aa733b) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #269   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines       882    882           
===================================
  Hits        842    842           
  Misses       40     40           
Impacted Files Coverage Δ
...sources/DSC_DiskAccessPath/DSC_DiskAccessPath.psm1 89% <ø> (ø)
.../DSCResources/DSC_WaitForDisk/DSC_WaitForDisk.psm1 100% <ø> (ø)
...e/Modules/StorageDsc.Common/StorageDsc.Common.psm1 100% <ø> (ø)
source/DSCResources/DSC_Disk/DSC_Disk.psm1 98% <100%> (ø)

@PlagueHO
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dshelb)

@PlagueHO PlagueHO merged commit b4f8a2a into dsccommunity:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants