Merge pull request #638 from johlju/fix-customrule

xPSDesiredStateConfiguration: Fix keywords to lower-case to align with guideline
dsccommunity · Sep 11, 2019 · 02853d1 · 02853d1
2 parents 19b04f0 + da3eb73
commit 02853d1
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Changes to xPSDesiredStateConfiguration
+  - Fix keywords to lower-case to align with guideline.
 - Added SMB PullServer support for publishing.
 
 ## 8.9.0.0

diff --git a/DSCResources/MSFT_xDSCWebService/MSFT_xDSCWebService.psm1 b/DSCResources/MSFT_xDSCWebService/MSFT_xDSCWebService.psm1
@@ -656,7 +656,7 @@ function Test-TargetResource
     $website = Get-Website -Name $EndpointName
     $stop = $true
 
-    :WebSiteTests Do
+    :WebSiteTests do
     {
         Write-Verbose -Message 'Check Ensure'
 
@@ -909,7 +909,7 @@ function Test-TargetResource
         }
         $stop = $false
     }
-    While($stop)
+    while ($stop)
 
     $desiredConfigurationMatch
 }

diff --git a/DSCResources/xFileUpload/xFileUpload.schema.psm1 b/DSCResources/xFileUpload/xFileUpload.schema.psm1
@@ -30,10 +30,10 @@
             -SourcePath 'C:\folder\file.txt' `
             -Credential $credential
 #>
-Configuration xFileUpload
+configuration xFileUpload
 {
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "")]
-
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '')]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('DscResource.AnalyzerRules\Measure-Keyword', '', Justification = 'Script resource name is seen as a keyword if this is not used.')]
     param
     (
         [Parameter(Mandatory = $true)]
@@ -56,7 +56,7 @@ Configuration xFileUpload
         $CertificateThumbprint
     )
 
-    $cacheLocation = "$env:ProgramData\Microsoft\Windows\PowerShell\Configuration\BuiltinProvCache\MSFT_xFileUpload"
+    $cacheLocation = "$env:ProgramData\Microsoft\Windows\PowerShell\configuration\BuiltinProvCache\MSFT_xFileUpload"
 
     if ($Credential)
     {

diff --git a/DSCResources/xGroupSet/xGroupSet.schema.psm1 b/DSCResources/xGroupSet/xGroupSet.schema.psm1
@@ -28,7 +28,7 @@ Import-Module -Name $script:resourceSetHelperFilePath
     .PARAMETER Credential
         The credential to resolve all groups and user accounts.
 #>
-Configuration xGroupSet
+configuration xGroupSet
 {
     [CmdletBinding()]
     param

diff --git a/DSCResources/xProcessSet/xProcessSet.schema.psm1 b/DSCResources/xProcessSet/xProcessSet.schema.psm1
@@ -43,7 +43,7 @@ Import-Module -Name $script:resourceSetHelperFilePath
         at this path will be overwritten. This property cannot be specified at the same time
         as Credential when running the processes as a local user.
 #>
-Configuration xProcessSet
+configuration xProcessSet
 {
     [CmdletBinding()]
     param

diff --git a/DSCResources/xServiceSet/xServiceSet.schema.psm1 b/DSCResources/xServiceSet/xServiceSet.schema.psm1
@@ -43,7 +43,7 @@ Import-Module -Name $script:resourceSetHelperFilePath
         right. The user account specified by this property must have access to the service
         executable paths in order to start the services.
 #>
-Configuration xServiceSet
+configuration xServiceSet
 {
     [CmdletBinding()]
     param

diff --git a/DSCResources/xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1 b/DSCResources/xWindowsFeatureSet/xWindowsFeatureSet.schema.psm1
@@ -33,7 +33,7 @@ Import-Module -Name $script:resourceSetHelperFilePath
         The custom file path to which to log this operation.
         If not passed in, the default log path will be used (%windir%\logs\ServerManager.log).
 #>
-Configuration xWindowsFeatureSet
+configuration xWindowsFeatureSet
 {
     [CmdletBinding()]
     param

diff --git a/DSCResources/xWindowsOptionalFeatureSet/xWindowsOptionalFeatureSet.schema.psm1 b/DSCResources/xWindowsOptionalFeatureSet/xWindowsOptionalFeatureSet.schema.psm1
@@ -33,7 +33,7 @@ Import-Module -Name $script:resourceSetHelperFilePath
     .PARAMETER LogLevel
         The level of detail to include in the log.
 #>
-Configuration xWindowsOptionalFeatureSet
+configuration xWindowsOptionalFeatureSet
 {
     [CmdletBinding()]
     param