Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 191 #277

Merged
merged 1 commit into from
Nov 25, 2016
Merged

Fix for issue 191 #277

merged 1 commit into from
Nov 25, 2016

Conversation

lfshr
Copy link
Contributor

@lfshr lfshr commented Nov 21, 2016

Fix for issue #191
Open a remote ServerManager connection using loopback.

Recreated in my lab (by complete accident). I don't feel like this should be the permanent fix. Why is ctor yielding no results?

Liam


This change is Reviewable

@msftclas
Copy link

Hi @LiamFisher92, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@kwirkykat kwirkykat added the needs review The pull request needs a code review. label Nov 21, 2016
@eshaparmar
Copy link
Contributor

Can you add it to the readme as well? Thanks!

@eshaparmar eshaparmar added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Nov 22, 2016
Open a remote ServerManager connection using loopback
@lfshr
Copy link
Contributor Author

lfshr commented Nov 22, 2016

@eshaparmar Commit updated. 😃

@lfshr
Copy link
Contributor Author

lfshr commented Nov 24, 2016

@eshaparmar Any update on this PR?

@eshaparmar eshaparmar merged commit 6090fa6 into dsccommunity:dev Nov 25, 2016
@eshaparmar eshaparmar removed the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants