Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in for the common tests validate module files and script files #427

Merged
merged 2 commits into from
Jun 18, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 17, 2018

  • Changes to xPSDesiredStateConfiguration
    • Opt-in for the common tests validate module files and script files.
    • All files change to encoding UTF-8 (without byte order mark).

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jun 17, 2018
@codecov-io
Copy link

codecov-io commented Jun 17, 2018

Codecov Report

Merging #427 into dev will not change coverage.
The diff coverage is 15%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #427   +/-   ##
===================================
  Coverage    74%    74%           
===================================
  Files        27     27           
  Lines      3995   3995           
  Branches      4      4           
===================================
  Hits       2957   2957           
  Misses     1034   1034           
  Partials      4      4

  - Opt-in for the common tests validate module files and script files.
  - All files change to encoding UTF-8 (without byte order mark).
@johlju
Copy link
Member Author

johlju commented Jun 18, 2018

:LGTM:


Reviewed 125 of 125 files at r1, 2 of 2 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@johlju johlju merged commit a5d6075 into dsccommunity:dev Jun 18, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jun 18, 2018
@johlju johlju deleted the opt-in-file-validation branch June 18, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants