xPackage: updated conditional statement to -ne to provide correct verbose output (fixes #446) #447

harnsin · 2018-10-09T19:44:55Z

Pull Request (PR) description

Fixes conditional statement for verbose output specifically on Line 793 in the xPackage resource to fix bug found while debugging.

This Pull Request (PR) fixes the following issues

Fixes xPackage: incorrect verbose message "Product installation cannot be determined" due to bug in conditional statement #446

Task list

Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
Resource documentation added/updated in README.md.
Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
Comment-based help added/updated.
Localization strings added/updated in all localization files as appropriate.
Examples appropriately added/updated.
Unit tests added/updated. See DSC Resource Testing Guidelines.
Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

codecov-io · 2018-10-09T20:33:26Z

Codecov Report

Merging #447 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #447   +/-   ##
===================================
  Coverage    72%    72%           
===================================
  Files        27     27           
  Lines      4031   4031           
  Branches      4      4           
===================================
  Hits       2922   2922           
  Misses     1105   1105           
  Partials      4      4

harnsin · 2018-10-12T18:31:43Z

@johlju I have tried closing and reopening the PR in hopes of resolving the error due to the integration tests in the xArchive resource, specifically the 'MSFT_xArchive.Integration.Tests' and 'MSFT_xArchive.EndToEnd.Tests' but unable to do so. I would appreciate help with these errors as they do not pertain to the change I have made in my pull request. Thank you in advance for your help.

mhendric

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

mhendric · 2018-11-02T17:57:02Z

I've reviewed this change. The suggested changes look good to me, and the failing Integration tests look completely unrelated to this change. Furthermore, all Integration and Unit that tests related to code in MSFT_xPackageResource are still passing. I recommend that this PR be allowed to be merged.

stale · 2018-11-22T23:22:11Z

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

mhendric · 2019-01-24T22:15:07Z

Hi @harnsin . Sorry for the extremely late responses on this. The failures with continuous integration should be resolved now. Can you rebase this PR and submit again? Hopefully it will pass and we can get this checked in. Thanks!

https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

mhendric · 2019-01-26T18:54:35Z

FYI, I updated the README to move the unreleased statement to the actual Unreleased section (it was under 8.5.0.0). @PlagueHO or @johlju , can one of you give this a re-review? Thanks.

PlagueHO

Reviewed 1 of 1 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved

PlagueHO · 2019-01-26T20:40:36Z

Should be good to go @mhendric once the AppVeyor finishes. Great stuff - love how these are all getting knocked off!

mhendric · 2019-01-27T01:53:56Z

Looks like this one may actually be failing due to this change (although I'm not yet sure how). I'm going to resolve conflicts and kick of another build. If this fails again, we'll need to troubleshoot

[00:19:41] Executing script C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsPackageCab.Integration.Tests.ps1
[00:19:53]   [-] Error occurred in test script 'C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsPackageCab.Integration.Tests.ps1' 0ms
[00:19:53]     RemoteException: fatal: unable to access 'https://github.com/PowerShell/DscResource.Tests/': Could not resolve host: github.com
[00:19:53]     at Enter-DscResourceTestEnvironment, C:\projects\xpsdesiredstateconfiguration\Tests\CommonTestHelper.psm1: line 748
[00:19:53]     at <ScriptBlock>, C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsPackageCab.Integration.Tests.ps1: line 3
[00:19:53]     at <ScriptBlock>, C:\Program Files\WindowsPowerShell\Modules\Pester\4.6.0\Pester.psm1: line 1095
[00:19:53]     at Invoke-Pester<End>, C:\Program Files\WindowsPowerShell\Modules\Pester\4.6.0\Pester.psm1: line 1121
[00:19:53]     at Invoke-AppveyorTestScriptTask, C:\projects\xpsdesiredstateconfiguration\DscResource.Tests\AppVeyor.psm1: line 792

mhendric · 2019-01-27T22:32:32Z

Hmmmmm. The next CI run failed again, but in a different test. The error is similar though; it was unable to connect to GitHub for some reason. Sounds like something we may want to track in an attempt to make tests in this module for resilient. I can't see how the below error is related to this particular change, but I would really like to see a successful CI run before we check this in. Thoughts?

[00:22:55] Executing script C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsFeature.Integration.Tests.ps1
[00:22:56]   [-] Error occurred in test script 'C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsFeature.Integration.Tests.ps1' 0ms
[00:22:56]     RemoteException: fatal: unable to access 'https://github.com/PowerShell/DscResource.Tests/': OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to github.com:443 
[00:22:56]     at Enter-DscResourceTestEnvironment, C:\projects\xpsdesiredstateconfiguration\Tests\CommonTestHelper.psm1: line 748
[00:22:56]     at <ScriptBlock>, C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsFeature.Integration.Tests.ps1: line 16
[00:22:56]     at <ScriptBlock>, C:\Program Files\WindowsPowerShell\Modules\Pester\4.6.0\Pester.psm1: line 1095
[00:22:56]     at Invoke-Pester<End>, C:\Program Files\WindowsPowerShell\Modules\Pester\4.6.0\Pester.psm1: line 1121
[00:22:56]     at Invoke-AppveyorTestScriptTask, C:\projects\xpsdesiredstateconfiguration\DscResource.Tests\AppVeyor.psm1: line 792

mhendric · 2019-01-28T00:00:15Z

...hey and look at that, the tests passed this time! Better merge before it changes its mind :).

mhendric

Reviewed 1 of 1 files at r4, 1 of 1 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved

johlju · 2019-01-28T17:07:11Z

@mhendric Must have been a temporary glitch in AppVeyor? I have not seen that error before, but glitches happens now and again (not often).

mhendric · 2019-01-28T17:10:53Z

Yeah, I think it was a temporary glitch. Hopefully whatever comes out of #505 will make it less likely for that to happen in the future.

harnsin · 2019-01-30T15:22:48Z

Appreciate the help all @mhendric @johlju @PlagueHO!

harnsin added 2 commits October 9, 2018 14:25

updated conditional statement

337e036

updated readme

69fc55b

harnsin closed this Oct 11, 2018

harnsin reopened this Oct 11, 2018

harnsin closed this Oct 12, 2018

harnsin reopened this Oct 12, 2018

harnsin closed this Oct 17, 2018

harnsin reopened this Oct 17, 2018

Merge branch 'dev' into xPackageBugFixHarnSin

d4eb591

mhendric mentioned this pull request Oct 31, 2018

MSFT_xArchive.EndToEnd.Tests.ps1 and MSFT_xArchive.Integration.Tests.ps1: Integration Tests Broken #457

Closed

mhendric reviewed Nov 2, 2018

View reviewed changes

mhendric mentioned this pull request Nov 8, 2018

MSFT_xWindowsProcess.Integration.Tests.ps1: Integration Tests Broken #458

Closed

harnsin closed this Nov 8, 2018

harnsin reopened this Nov 8, 2018

stale bot added the abandoned The pull request has been abandoned. label Nov 22, 2018

mhendric removed the abandoned The pull request has been abandoned. label Jan 24, 2019

Merge branch 'dev' into xPackageBugFixHarnSin

fbf0ed3

PlagueHO added the needs review The pull request needs a code review. label Jan 25, 2019

PlagueHO and others added 3 commits January 26, 2019 14:20

Merge branch 'dev' into xPackageBugFixHarnSin

e0f2146

Merge branch 'dev' into xPackageBugFixHarnSin

bf90c35

Update README.md

c3e4d01

Merge branch 'dev' into xPackageBugFixHarnSin

66c60e9

PlagueHO approved these changes Jan 26, 2019

View reviewed changes

mhendric added 2 commits January 26, 2019 19:54

Merge branch 'dev' into xPackageBugFixHarnSin

b95bc6a

Merge branch 'dev' into xPackageBugFixHarnSin

753b772

mhendric mentioned this pull request Jan 27, 2019

Some Integration Tests Can Fail When Temporarily Unable to Connect to GitHub #505

Closed

Update README.md

245428c

mhendric approved these changes Jan 28, 2019

View reviewed changes

mhendric merged commit ecaa8ac into dsccommunity:dev Jan 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xPackage: updated conditional statement to -ne to provide correct verbose output (fixes #446) #447

xPackage: updated conditional statement to -ne to provide correct verbose output (fixes #446) #447

harnsin commented Oct 9, 2018 •

edited by joeyaiello

Loading

codecov-io commented Oct 9, 2018 •

edited

Loading

harnsin commented Oct 12, 2018

mhendric left a comment

mhendric commented Nov 2, 2018

stale bot commented Nov 22, 2018

mhendric commented Jan 24, 2019

mhendric commented Jan 26, 2019

PlagueHO left a comment

PlagueHO commented Jan 26, 2019

mhendric commented Jan 27, 2019

mhendric commented Jan 27, 2019 •

edited

Loading

mhendric commented Jan 28, 2019

mhendric left a comment

johlju commented Jan 28, 2019

mhendric commented Jan 28, 2019

harnsin commented Jan 30, 2019

xPackage: updated conditional statement to -ne to provide correct verbose output (fixes #446) #447

xPackage: updated conditional statement to -ne to provide correct verbose output (fixes #446) #447

Conversation

harnsin commented Oct 9, 2018 • edited by joeyaiello Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

codecov-io commented Oct 9, 2018 • edited Loading

Codecov Report

harnsin commented Oct 12, 2018

mhendric left a comment

Choose a reason for hiding this comment

mhendric commented Nov 2, 2018

stale bot commented Nov 22, 2018

mhendric commented Jan 24, 2019

mhendric commented Jan 26, 2019

PlagueHO left a comment

Choose a reason for hiding this comment

PlagueHO commented Jan 26, 2019

mhendric commented Jan 27, 2019

mhendric commented Jan 27, 2019 • edited Loading

mhendric commented Jan 28, 2019

mhendric left a comment

Choose a reason for hiding this comment

johlju commented Jan 28, 2019

mhendric commented Jan 28, 2019

harnsin commented Jan 30, 2019

harnsin commented Oct 9, 2018 •

edited by joeyaiello

Loading

codecov-io commented Oct 9, 2018 •

edited

Loading

mhendric commented Jan 27, 2019 •

edited

Loading