Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFT_xUserResource.psm1: Fix script analyzer issues #553

Merged
merged 2 commits into from
Feb 16, 2019

Conversation

mhendric
Copy link
Contributor

@mhendric mhendric commented Feb 15, 2019

Pull Request (PR) description

Fixes remaining script analyzer issues in MSFT_xUserResource.psm1.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in
    CHANGELOG.md. Entry should say what was changed, and how that affects
    users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as
    appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See
    DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Resource Testing Guidelines.
  • New/changed code adheres to
    DSC Resource Style Guidelines and Best Practices

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #553 into dev will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #553   +/-   ##
===================================
  Coverage    74%    74%           
===================================
  Files        27     27           
  Lines      4029   4029           
  Branches      4      4           
===================================
  Hits       3009   3009           
  Misses     1016   1016           
  Partials      4      4

@PlagueHO
Copy link
Member

Will review once the conflicts are fixed.

@PlagueHO PlagueHO self-requested a review February 15, 2019 19:34
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Feb 15, 2019
Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO
Copy link
Member

Just waiting for the CI to finish before merging.

@PlagueHO PlagueHO added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Feb 15, 2019
@mhendric mhendric merged commit c3bbbe5 into dsccommunity:dev Feb 16, 2019
@mhendric mhendric deleted the FixUserResource branch April 7, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSFT_xUserResource.psm1: Fix Custom DSC Resource Kit PSSA rule violations
3 participants