Tests\Integration\xWindowsOptionalFeatureSet.Integration.Tests.ps1: Fix issues with disabled feature states #587
Conversation
… up in a state of DisabledWithPayloadRemoved
Codecov Report
@@ Coverage Diff @@
## dev #587 +/- ##
===================================
Coverage 74% 74%
===================================
Files 27 27
Lines 4074 4074
Branches 4 4
===================================
Hits 3032 3032
Misses 1038 1038
Partials 4 4 |
There was a problem hiding this comment.
Small comment on the Changelog
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @mhendric)
CHANGELOG.md, line 27 at r1 (raw file):
- Changes to `Tests\Integration\xWindowsOptionalFeatureSet.Integration.Tests.ps1` - Fixes issue where tests fail if disabled Windows Optional Features in up
This scentence doesn't make sense to me. Typo maybe? "end up in a state"?
… up in a state of DisabledWithPayloadRemoved - Post Review
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ykuijs)
CHANGELOG.md, line 27 at r1 (raw file):
Previously, ykuijs (Yorick Kuijs) wrote…
This scentence doesn't make sense to me. Typo maybe? "end up in a state"?
That was indeed a type. Good catch! Fixed.
… up in a state of DisabledWithPayloadRemoved - Post Review
TypO ! Not type. Typing is hard... |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
mhendric
added
ready for merge
|
@PlagueHO , I'll leave this one for you to merge since it's my PR and someone else did the code review. Thanks. |
|
Hi @ykuijs - could you resolve conflicts? |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6.
Reviewable status:
Pull Request (PR) description
Fixes issue where tests fail if disabled Windows Optional Features in up in a state of DisabledWithPayloadRemoved.
This Pull Request (PR) fixes the following issues
Task list
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
and comment-based help.
appropriate.
DSC Resource Testing Guidelines.
DSC Resource Testing Guidelines.
DSC Resource Style Guidelines and Best Practices
This change is