Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Pipeline Changes #684

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Miscellaneous Pipeline Changes #684

merged 2 commits into from
Apr 29, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 28, 2020 •
edited
Loading

Pull Request (PR) description

Update ModuleBuilder to Latest.
Merge HISTORIC_CHANGELOG.md into CHANGELOG.md.
Change Azure DevOps Pipeline trigger to include source/*.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing for me?

This change is Reviewable

johlju
johlju approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Apr 28, 2020
johlju
johlju requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

CHANGELOG.md, line 675 at r1 (raw file):

## [6.0.0.0] - 2017-02-303

I missed this, but the tests didn't 😉

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. labels Apr 28, 2020
PlagueHO
PlagueHO commented Apr 28, 2020
View reviewed changes
Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @johlju)

CHANGELOG.md, line 675 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
## [6.0.0.0] - 2017-02-303

I missied this, but the tests didn't 😉

Woop nice!!!! Fixed!

PlagueHO
PlagueHO commented Apr 28, 2020
View reviewed changes
Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign off again @johlju ? Thank you!

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @johlju)

johlju
johlju approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit f6620ae into dsccommunity:master Apr 29, 2020
@PlagueHO PlagueHO deleted the Issue-682-and-683 branch April 29, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Milestone
No milestone
2 participants
@PlagueHO @johlju