kafka producer settings were added #80
Conversation
There was a problem hiding this comment.
See file comments - nothing major.
Also, can you make a fixture cookbook that sets up a very simple kafka broker cluster, then also make a recipe in the onms_lwrp_test fixture cookbook that manipulates the required attributes to work with that broker cluster? Then add a kitchen suite that uses those recipes and write an inspec test that verifies that kafka is running and the feature is installed and the collection set topic exists and that opennms is a producer on the configured topic. If you can't get the suite to run in Windows we can find another place to run it.
attributes/default.rb
Outdated
| @@ -2130,3 +2130,4 @@ | |||
| 'topologyEdgeTopic' => 'edges', 'metricTopic' => 'metrics', 'eventFilter' => '', 'alarmFilter' => '', 'forward.metrics' => false, | |||
| 'nodeRefreshTimeoutMs' => 300000, 'alarmSyncIntervalMs' => 300000, 'suppressIncrementalAlarms' => true, 'kafkaSendQueueCapacity' => 1000, | |||
| 'startAlarmSyncWithCleanState' => false} | |||
| default['opennms']['kafka']['producer'] ['client'] = {} | |||
There was a problem hiding this comment.
I think there's an extra space here? and maybe add a short comment above explaining what the attribute does
recipes/kafka_producer.rb
Outdated
| owner 'root' | ||
| group 'root' | ||
| mode 00664 | ||
| only_if { mv.to_i >= 26} |
There was a problem hiding this comment.
this resource and the other templates you added would run on anything >= 26 but a template only exists in 26 - either change the guard or add more templates please
Please review.
Tests were added, but i haven't changes the .kitchen.yml file as i don't know how to change it correctly.