Skip to content

Commit

Permalink
Merge pull request msysgit#240: remote-https: do not call fetch-pack …
Browse files Browse the repository at this point in the history
…if using gvfs helper

The `gvfs-helper` is supposed to avoid calling `git fetch-pack` by downloading objects through the GVFS protocol instead. For some reason, some `git fetch` calls still end up calling `git fetch-pack` which gets a complaint from the remote because it does not support that kind of fetch.

Put a hard stop in the `fetch_git()` method to prevent this process run.
  • Loading branch information
derrickstolee authored Feb 4, 2020
2 parents 14b30a3 + 0aac91c commit 87453bb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions remote-curl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,9 @@ static int fetch_git(struct discovery *heads,
struct argv_array args = ARGV_ARRAY_INIT;
struct strbuf rpc_result = STRBUF_INIT;

if (core_use_gvfs_helper)
return 0;

argv_array_pushl(&args, "fetch-pack", "--stateless-rpc",
"--stdin", "--lock-pack", NULL);
if (options.followtags)
Expand Down

0 comments on commit 87453bb

Please sign in to comment.