Skip to content

Commit

Permalink
Previous documentation defined booleans as yes or no (ansible-com…
Browse files Browse the repository at this point in the history
…munity/community-topics#116).  This was changed in ansible/ansible#78921 to use `true` or `false`.

Do not use release candidates or alpha releases in Jenkinsfiles
  • Loading branch information
Dougal Seeley committed Oct 8, 2023
1 parent 7f4fb56 commit b0e452a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Create a playbook file to be called from within another, e.g:`test_nested.yml`:
```yaml
- name: test
hosts: localhost
gather_facts: no
gather_facts: false
tasks:
- debug: msg="Child playbook - 1"

Expand All @@ -27,7 +27,7 @@ Create the parent file. Either: `test_parent__cmdline.yml`:
```yaml
- name: test
hosts: localhost
gather_facts: no
gather_facts: false
tasks:
- debug: msg="Parent playbook"
Expand All @@ -41,7 +41,7 @@ or: `test_parent__args.yml`:
```yaml
- name: test
hosts: localhost
gather_facts: no
gather_facts: false
tasks:
- debug: msg="Parent playbook"
Expand Down
2 changes: 1 addition & 1 deletion jenkinsfiles/Jenkinsfile_release_tag
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def PROJECT_URL_DEFAULT = "https://github.com/dseeley/nested_playbook"
def PROJECT_BRANCH_DEFAULT = "master" //Set the default git branch to use if we're not running an SCM job (e.g. if we're copying/pasting into a pipeline script)

def pypi_ansible = ["curl", "-s", "-H", "Accept: application/json", "-H", "Content-type: application/json", "GET", "https://pypi.org/pypi/ansible/json"].execute().text
def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).releases.keySet()[-1]
def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).info.version // Use `info.version` instead of `.releases.keySet()[-1]`, to avoid alpha and release candidate versions

//This allows us to create our own Docker image for this specific use-case. Once it is built, it will not be rebuilt, so only adds delay the first time we use it.
def create_custom_image(image_name, build_opts = "") {
Expand Down
2 changes: 1 addition & 1 deletion jenkinsfiles/Jenkinsfile_release_tag__auto
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!groovy

def pypi_ansible = ["curl", "-s", "-H", "Accept: application/json", "-H", "Content-type: application/json", "GET", "https://pypi.org/pypi/ansible/json"].execute().text
def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).releases.keySet()[-1]
def pypi_ansible_latest = new groovy.json.JsonSlurper().parseText(pypi_ansible).info.version // Use `info.version` instead of `.releases.keySet()[-1]`, to avoid alpha and release candidate versions

node {
stage('Call ansible/nested_playbook-release-tag') {
Expand Down

0 comments on commit b0e452a

Please sign in to comment.