Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff rule F632: comparison of literals #27

Merged
merged 1 commit into from
May 12, 2023
Merged

Fix ruff rule F632: comparison of literals #27

merged 1 commit into from
May 12, 2023

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented May 11, 2023 •
edited
Loading

Supports #21, incrementally getting more rules to pass.

@connortann connortann changed the title Fix/ruff F632 Fix ruff rule F632: comparison of literals May 11, 2023
@connortann connortann marked this pull request as ready for review May 12, 2023 08:20
dsgibbons
dsgibbons approved these changes May 12, 2023
View reviewed changes
Copy link
Owner

@dsgibbons dsgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - this is a good one to get through to save a few warnings in the test suite

@dsgibbons dsgibbons merged commit 31f2245 into dsgibbons:master May 12, 2023
@connortann connortann deleted the fix/ruff-F632 branch May 15, 2023 08:51
@connortann connortann mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgibbons dsgibbons dsgibbons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connortann @dsgibbons