RFC - All Comment as Nodes [WIP] #757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
force-pushed
the
commentNodesRfc
branch
from
8211721
to
7f47e48
Compare
dsherret
force-pushed
the
master
branch
2 times, most recently
from
dfac86d
to
3848522
Compare
dsherret
force-pushed
the
latest
branch
4 times, most recently
from
dedc584
to
a7072fc
Compare
Robbbo-T
approved these changes
Jun 17, 2024
Repository owner
deleted a comment from
Robbbo-T
Jun 17, 2024
Repository owner
deleted a comment from
Robbbo-T
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for a new
Node#getChildrenWithComments()and new way of parsing comment members & statements.Demo: https://ts-ast-viewer.com/comments/index.html#
For #737.
Note: I do not bother following RFC 2119 for these, but I probably should in the future...