Skip to content
This repository has been archived by the owner on Oct 15, 2018. It is now read-only.

Improved get and set accessor support #176

Closed
dsherret opened this issue Aug 6, 2016 · 0 comments
Closed

Improved get and set accessor support #176

dsherret opened this issue Aug 6, 2016 · 0 comments

Comments

@dsherret
Copy link
Owner

dsherret commented Aug 6, 2016

As was discovered in #160, there are some problems with the current implementation of accessors. It uses an isReadonly property to tell if an accessor only has a get accessor.

Overall, the current implementation is not very good. It would be better to have a kind property with the following enum:

enum ClassPropertyKind {
    Normal = 0,
    GetAccessor = 1 << 0,
    SetAccessor = 1 << 1,
    GetSetAccessor = GetAccessor | SetAccessor
}

What was also discovered is that currently only get and get/set accessors are supported—not set-only accessors. The code will be changed to support this scenario as well.

@dsherret dsherret added this to the Version 6.0 milestone Aug 6, 2016
@dsherret dsherret closed this as completed Aug 6, 2016
dsherret added a commit that referenced this issue Aug 6, 2016
dsherret added a commit that referenced this issue Aug 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant