Watchface improvements + omniBLE/Omnikit fixes #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Backport of OmniBLE #114 and OmniKit #27 (fixes Loop issue #2117) UI fixes and improvements for various pod setup restart situations + Gracefully handle restarts when prime or insert cannula is in progress + Have the view model init funcs test for and handle resume cases + Improved PodPairer to include the pumpManager podCommState var + Fix PodPairer.podIsActivated to properly handle a paired pod + Start with pairAndPrime state when prime has not finalized + Update PairPodViewModelState priming value to use an optional + Rename func & enum names from pair to pairAndPrime for clarity + Improved CannulaInserter to include cannulaInsertionSuccessfullyStarted var * For an in-progress insert cannula compute a wait time on remaining bolus + Fix checkCannulaInsertionFinished() to use checkingInsertion state + Add cannulaInsertionSuccessfullyStarted var to podState + Update PairPodViewModelState priming value to use an optional + Update PumpStatusHighlight to "Finish Setup" while activating a paired pod New resetPerPodPumpManagerState func called when starting/forgetting pod + Reset podAttachmentConfirmed state variable for each new pod + Reset state.acknowledgedTimeOffsetAlert var in case it gets used + Reset all per pod PumpManagerAlerts for each new pod + Use retractAlert func to handle the state.activeAlerts removal + Add comment noting that podCommState.deactivating value is never returned + Add some missing state initializion for simulator in OmniKit jumpStartPod() * Updates to virtually eliminate user retries on pod setup resumes + Have PairAndPrime ViewModel do an automatic retry on error + Have InsertCannula ViewModel do an automatic retry on error + Add resumingPodSetup func to attempt a getStatus and sleep on errors + Added some improved and updated pumpManager comments + Have pumpManager detect pod setup resumes to invoke resumingPodSetup() + Added additional isConnected handling to OmniBLE resumingPodSetup() + Correct & relocate OmniKit insulinType guard as per OmniBLE + Update OmniKit SessionsRunResult variable use to match OmniBLE * Updates to virtually eliminate user retries on pod setup resumes + Have PairAndPrime ViewModel do an automatic retry on error + Have InsertCannula ViewModel do an automatic retry on error + Add resumingPodSetup func to attempt a getStatus and sleep on errors + Added some improved and updated pumpManager comments + Have pumpManager detect pod setup resumes to invoke resumingPodSetup() + Added additional isConnected handling to OmniBLE resumingPodSetup() + Correct & relocate OmniKit insulinType guard as per OmniBLE + Update OmniKit SessionsRunResult variable use to match OmniBLE (itsmojo commit c564516)
…go as official version, just vhanged text strings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.