Add support for dotnet build #41
Conversation
|
Progress, builds/doesn't error out, but doesn't work yet. Investigating. Update: works. just had a non-signed assm cached in the SignedAssemblies directory so it was skipping based on the Mvid check. |
| @@ -217,5 +217,40 @@ private static byte[] GetKeyTokenFromKey(byte[] fullKey) | |||
|
|
|||
| return hash.Reverse().Take(8).ToArray(); | |||
| } | |||
|
|
|||
| // From Cecil | |||
| // https://github.com/jbevain/cecil/pull/548/files | |||
There was a problem hiding this comment.
So we're copying code from Cecil because it's not a public API? Would it make sense for Cecil to add public APIs for what we need?
There was a problem hiding this comment.
Correct. I've suggested that but it's not likely to be soon. Fody has its own private copy of StrongNameKeyPair.
There was a problem hiding this comment.
There was a problem hiding this comment.
Why wouldn't this logic just live in Microsoft.CodeAnalysis? There is already a DesktopStrongNameProvider.
| @@ -0,0 +1,60 @@ | |||
| trigger: | |||
There was a problem hiding this comment.
Did you hook this up to a pipeline anywhere and test it? How do you expect me to hook it up to CI?
There was a problem hiding this comment.
Setup a free Azure DevOps pipeline? :)
I haven't tested it but I'm mostly sure it works ;) It's based on many others I've done.
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "version": "0.1", | |||
There was a problem hiding this comment.
What will the versions end up looking like here?
There was a problem hiding this comment.
They'll be 0.1.{height} since last increment.
There was a problem hiding this comment.
Does that mean that the NuGet package versions will also include the commit height? I'd prefer to avoid that.
There was a problem hiding this comment.
Up to you -- I've found that no one seems to care about the patch version; you can see it in action in any of my libraries (rx/ix, humanizer, etc). It's a way to get a reproducible build/version number that auto versions. Driven by commit depth has been the most reliable way.
I can remove auto versioning if you have another approach you prefer.
There was a problem hiding this comment.
I like GitVersion personally. I suppose you can drive it through GitInfo instead.
|
You can see it working by looking at the commits/builds here: |
Fixes #17
This PR adds support for building with
dotneton CoreCLR. It uses Cecil 0.11, which added support for that.It also converts all the projects to SDK-style, adds an Azure Pipelines yaml and auto versioning.