Fix logger exception on instance provisioning timeout (#1697)

Fixes: #1696

src/dstack/_internal/server/background/tasks/process_instances.py

@@ -196,11 +196,11 @@ async def _add_remote(instance: InstanceModel) -> None:
     ) + timedelta(seconds=PROVISIONING_TIMEOUT_SECONDS)
     if retry_duration_deadline < get_current_datetime():
         instance.status = InstanceStatus.TERMINATED
-        instance.termination_reason = "Proivisioning timeout expired"
+        instance.termination_reason = "Provisioning timeout expired"
         logger.warning(
-            "Failed to start instance in %s seconds. Terminating...",
-            PROVISIONING_TIMEOUT_SECONDS,
+            "Failed to start instance %s in %d seconds. Terminating...",
             instance.name,
+            PROVISIONING_TIMEOUT_SECONDS,
             extra={
                 "instance_name": instance.name,
                 "instance_status": InstanceStatus.TERMINATED.value,

src/tests/_internal/server/background/tasks/test_process_instances.py

@@ -242,6 +242,29 @@ async def test_terminate_by_idle_timeout(self, test_db, session: AsyncSession):
         assert instance.termination_reason == "Idle timeout"
 
 
+class TestOnPremInstanceTerminateProvisionTimeoutExpired:
+    @pytest.mark.asyncio
+    @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)
+    async def test_terminate_by_idle_timeout(self, test_db, session: AsyncSession):
+        project = await create_project(session=session)
+        pool = await create_pool(session, project)
+        instance = await create_instance(
+            session,
+            project,
+            pool,
+            status=InstanceStatus.PENDING,
+            created_at=get_current_datetime() - dt.timedelta(days=100),
+        )
+        instance.remote_connection_info = "{}"
+        await session.commit()
+
+        await process_instances()
+
+        await session.refresh(instance)
+        assert instance.status == InstanceStatus.TERMINATED
+        assert instance.termination_reason == "Provisioning timeout expired"
+
+
 class TestTerminate:
     @pytest.mark.asyncio
     @pytest.mark.parametrize("test_db", ["sqlite", "postgres"], indirect=True)